Return-path: Received: from 128-177-27-249.ip.openhosting.com ([128.177.27.249]:38179 "EHLO jmalinen.user.openhosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751885Ab0L1JZV (ORCPT ); Tue, 28 Dec 2010 04:25:21 -0500 Date: Tue, 28 Dec 2010 11:25:10 +0200 From: Jouni Malinen To: Johannes Berg Cc: Bruno Randolf , linville@tuxdriver.com, linux-wireless@vger.kernel.org, mcgrof@gmail.com Subject: Re: [PATCH RFC] mac80211: Extend channel to frequency mapping for 802.11j Message-ID: <20101228092510.GA22967@jm.kir.nu> References: <20101224074410.16337.90008.stgit@localhost6.localdomain6> <1293447459.3544.1.camel@jlt3.sipsolutions.net> <201012281431.46536.br1@einfach.org> <1293525513.3526.0.camel@jlt3.sipsolutions.net> <20101228090102.GA22580@jm.kir.nu> <1293527282.3526.2.camel@jlt3.sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1293527282.3526.2.camel@jlt3.sipsolutions.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Dec 28, 2010 at 10:08:02AM +0100, Johannes Berg wrote: > On Tue, 2010-12-28 at 11:01 +0200, Jouni Malinen wrote: > > Quite a few.. At least 4.85 GHz and 3.0 GHz for 20 MHz channels and more > > for 5 and 10 MHz channels (4.9375 GHz, 4.89 GHz, 3.0025 GHz, 4.0025 GHz, > > 5.0025 GHz) in channels defined by IEEE 802.11. > > That's what I kinda thought ... doesn't that mean this patch is > insufficient? Depends on what it is trying to achieve. Based on the Subject: line, it aims to add support for channels defined in 802.11j and it does indeed seem to do that (most of those odd channel starting frequencies come from 802.11y). If the goal were to cover all channels defined in the current IEEE 802.11 standard, then sure, it would be insufficient, but it is not like we support 3.6 GHz band or sub-20 MHz channels anyway, so only the 4.85 GHz starting frequency for some emergency channels from 802.11y would not be covered. -- Jouni Malinen PGP id EFC895FA