Return-path: Received: from smtp.nokia.com ([147.243.128.26]:56867 "EHLO mgw-da02.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753093Ab0L1Lfn (ORCPT ); Tue, 28 Dec 2010 06:35:43 -0500 Subject: Re: [PATCH v2 14/18] wl1271: AP mode - record TX configuration settings From: Luciano Coelho To: ext Arik Nemtsov Cc: linux-wireless@vger.kernel.org In-Reply-To: <1293028057-6212-15-git-send-email-arik@wizery.com> References: <1293028057-6212-1-git-send-email-arik@wizery.com> <1293028057-6212-15-git-send-email-arik@wizery.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 28 Dec 2010 13:35:39 +0200 Message-ID: <1293536140.24274.16.camel@chilepepper> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2010-12-22 at 16:27 +0200, ext Arik Nemtsov wrote: > Record TX configuration settings in the "conf" member of our global > structure (struct wl1271) if conf_tx is called when the firmware is > not loaded. > > Later on when the firmware is loaded, we apply the tx conf as part of > the init sequence. > > Important for AP mode since conf_tx is called before add_interface > (where the firmware is initialized). > > Signed-off-by: Arik Nemtsov > --- [...] > diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c > index 3cc4f79..71a67f1 100644 > --- a/drivers/net/wireless/wl12xx/main.c > +++ b/drivers/net/wireless/wl12xx/main.c > @@ -1462,6 +1462,8 @@ static int wl1271_op_config(struct ieee80211_hw *hw, u32 changed) > goto out; > } > > + is_ap = (wl->bss_type == BSS_TYPE_AP_BSS); > + > ret = wl1271_ps_elp_wakeup(wl, false); > if (ret < 0) > goto out; This is cross-patch and should be in 10/18. -- Cheers, Luca.