From: Bruno Randolf <br1@einfach.org>
To: Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH 2/3] nl80211: Export available antennas
Date: Tue, 7 Dec 2010 11:17:18 +0900
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
References: <20101206034529.11462.48097.stgit@localhost6.localdomain6> <201012061730.16102.br1@einfach.org> <1291624400.3506.3.camel@jlt3.sipsolutions.net>
In-Reply-To: <1291624400.3506.3.camel@jlt3.sipsolutions.net>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Message-Id: <201012071117.19067.br1@einfach.org>
Sender: linux-wireless-owner@vger.kernel.org

On Mon December 6 2010 17:33:20 Johannes Berg wrote:
> > > Finally, you should check for nl80211 that the given tx/rx masks fall
> > > into the available antennas mask.
> > 
> > Allright, I can do that. Would you prefer to reject the command in this
> > case or just apply the available mask?
> 
> I'd reject it, since userspace could have checked whether it was valid.

Hmm, been thinking about it: the "iw phyX set antenna all" will not work in 
that case. Unless we get the available antennas before setting "all" in iw, 
which seems like a lot of overhead...

Alternatively we can either apply the mask in mac80211 or just hand the 
antenna masks as they are to the driver, which is what we do now.

I think either way it's not a big deal.

bruno