Return-path: Received: from lo.gmane.org ([80.91.229.12]:44110 "EHLO lo.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932072Ab1AKM5m (ORCPT ); Tue, 11 Jan 2011 07:57:42 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PcdnB-0001vK-2v for linux-wireless@vger.kernel.org; Tue, 11 Jan 2011 13:57:41 +0100 Received: from proxyext.iabg.de ([proxyext.iabg.de]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 Jan 2011 13:57:41 +0100 Received: from pommnitz by proxyext.iabg.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 Jan 2011 13:57:41 +0100 To: linux-wireless@vger.kernel.org From: jpo234 Subject: Re: [PATCH v2 2/4] iw: Add channel busy time to survey Date: Tue, 11 Jan 2011 12:57:27 +0000 (UTC) Message-ID: References: <20110111005107.10231.81618.stgit@localhost6.localdomain6> <20110111005112.10231.46375.stgit@localhost6.localdomain6> <1294734744.3611.3.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Johannes Berg writes: > because uint64_t isn't guaranteed to be unsigned long long (in fact, it > is unsigned long on many machines). Please look at the commit and check. In the commit you did a cast to unsigned long long. While this works, it's depends on gcc-ism, e.g. long long support. The C99 way would be to use the PRIu64 macro (see stdint.h). see http://www.dinkumware.com/manuals/?manual=compleat&page=inttypes.html#PRIu64