Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:42532 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755735Ab1ATXDx (ORCPT ); Thu, 20 Jan 2011 18:03:53 -0500 Received: by iyj18 with SMTP id 18so1089419iyj.19 for ; Thu, 20 Jan 2011 15:03:53 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20110120075130.GA3431@vmraj-lnx.users.atheros.com> References: <1295452063-13828-1-git-send-email-rmanoharan@atheros.com> <1295452063-13828-2-git-send-email-rmanoharan@atheros.com> <20110120075130.GA3431@vmraj-lnx.users.atheros.com> From: "Luis R. Rodriguez" Date: Thu, 20 Jan 2011 15:02:20 -0800 Message-ID: Subject: Re: [PATCH 2/2] ath9k: Fix power save usage count imbalance on deinit To: Rajkumar Manoharan , Paul Stewart Cc: Rajkumar Manoharan , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jan 19, 2011 at 11:51 PM, Rajkumar Manoharan wrote: > On Thu, Jan 20, 2011 at 12:54:56AM +0530, Luis R. Rodriguez wrote: >> On Wed, Jan 19, 2011 at 7:47 AM, Rajkumar Manoharan >> wrote: >> > Upon unloading the driver, the ps_usecount is incremented >> > before configuring gpio registers in deinit_device. >> > But it is failed to restore the ps_usecount after that. >> > The problem is that the chip is moved to FULL SLEEP >> > by radio_disable when mac80211 is reporting as idle >> > though ps_usecount is not zero. >> > >> > This patch retores ps_usecount properly and ensures that >> > the chip is always moved to full sleep only if ps usage >> > counte is zero which helps in debugging. And also fixes >> > the following warning. >> > >> > ath: DMA failed to stop in 10 ms AR_CR=0xdeadbeef AR_DIAG_SW=0xdeadbeef >> > ath: Could not stop RX, we could be confusing the DMA engine when we >> > start RX up >> > ------------[ cut here ]------------ >> > WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536 >> > ath_stoprecv+0xf4/0x100 [ath9k]() >> > >> >> Are you sure this hunk does not regress the suspend/resume case when >> using the new dbus API? >> > I verfied the suspend/resume case with AR9280 card. But I don't > understand how the new dbus API is related with this patch? Paul, if you get a chance to give this a spin before it gets merged it'd be appreciated. Luis