Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:62378 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752920Ab1AZRgt (ORCPT ); Wed, 26 Jan 2011 12:36:49 -0500 Received: by iwn9 with SMTP id 9so1099307iwn.19 for ; Wed, 26 Jan 2011 09:36:49 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <19776.23002.952371.103267@gargle.gargle.HOWL> References: <19776.19422.571177.795197@gargle.gargle.HOWL> <19776.23002.952371.103267@gargle.gargle.HOWL> From: "Luis R. Rodriguez" Date: Wed, 26 Jan 2011 09:36:28 -0800 Message-ID: Subject: Re: [PATCH] ath9k_hw: Fix INI fixup To: Sujith Cc: "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jan 26, 2011 at 9:28 AM, Sujith wrote: > Luis R. Rodriguez wrote: >> On Wed, Jan 26, 2011 at 8:29 AM, Sujith wrote: >> > From: Sujith Manoharan >> > >> > Commit "ath9k_hw: move AR9280 PCI EEPROM fix to eeprom_def.c" >> > changed the behavior of INI overriding which is needed only >> > for PCI cards. Revert to the original check. >> > >> > Signed-off-by: Sujith Manoharan >> >> You leave me no option but to come out of e-mail reply slumber. What >> issues was this causing? > > The INI fixup is required only for AR9280 PCI cards. Changing it to a SREV > check that includes all chipsets above AR9280 would mean changing the initvals > for other cards too. The couple of cards I have did not hit this check, > but that doesn't mean that there are no weirdly configured cards out there... Thanks, the reason I ask was to determine if this was a stable fix. mcgrof@tux ~/linux-2.6-allstable (git::master)$ git describe --contains 57b98384e5450996300d77ece61739b58325a84f v2.6.35-rc1~473^2~167^2~208 Luis