Return-path: Received: from mail.atheros.com ([12.19.149.2]:33044 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753412Ab1ACE4U (ORCPT ); Sun, 2 Jan 2011 23:56:20 -0500 Received: from mail.atheros.com ([10.10.20.108]) by sidewinder.atheros.com for ; Sun, 02 Jan 2011 20:56:03 -0800 Message-ID: <4D2156E6.7040307@atheros.com> Date: Mon, 3 Jan 2011 10:26:06 +0530 From: Mohammed Shafi MIME-Version: 1.0 To: Kalle Valo CC: Jouni Malinen , "linux-wireless@vger.kernel.org" , Luis Rodriguez , "linville@tuxdriver.com" Subject: Re: [PATCH] ath9k: Reset keycache on resume References: <1293000612-10884-1-git-send-email-mshajakhan@atheros.com> <8762u9ge8m.fsf@purkki.adurom.net> In-Reply-To: <8762u9ge8m.fsf@purkki.adurom.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On Saturday 01 January 2011 03:03 PM, Kalle Valo wrote: > Hi, > > a minor nitpick: > Thanks for pointing it out. > Mohammed Shafi Shajakhan writes: > > >> From: Mohammed Shafi Shajakhan >> > This means that Mohammed is the author of the patch. > > [...] > Jouni is the author. > >> Signed-off-by: Jouni Malinen >> Signed-off-by: Mohammed Shafi Shajakhan >> > But here the author's sob line should be first one, the order is from > top to bottom. If Mohammed is the author, the sob lines should be > reversed. But if Jouni actually is the author, the From line should be > fixed. > > Of course this is just a style issue and doesn't matter that much, but > it's still nice to get it right. > >