Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:40479 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752380Ab1AZIcE (ORCPT ); Wed, 26 Jan 2011 03:32:04 -0500 Subject: Re: [PATCH v2 2/6] nl80211: Pass probe response data to drivers From: Johannes Berg To: Arik Nemtsov Cc: linux-wireless@vger.kernel.org, Luciano Coelho , "John W. Linville" In-Reply-To: References: <1295816579-28925-1-git-send-email-arik@wizery.com> <1295816579-28925-3-git-send-email-arik@wizery.com> <1295868924.3639.2.camel@jlt3.sipsolutions.net> <1295950325.3650.5.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Date: Wed, 26 Jan 2011 09:32:00 +0100 Message-ID: <1296030720.3635.14.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2011-01-26 at 08:00 +0200, Arik Nemtsov wrote: > >> > Why use a separate command for this, and not do it like the SSID? I also > >> > >> Its only relevant to AP-mode (at least for now) so bss_conf didn't > >> seem appropriate. > >> Also since its a dynamically allocated buffer it should be protected by RCU. > > > > But all that is unrelated to the nl80211 API, no? Also the SSID already > > uses bss_conf too, and it's AP mode too... > > Do you have a preferred alternative? What's wrong with putting it in the same place as the SSID? johannes