Return-path: Received: from mail-gx0-f174.google.com ([209.85.161.174]:48455 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752355Ab1A3Kez (ORCPT ); Sun, 30 Jan 2011 05:34:55 -0500 Received: by gxk9 with SMTP id 9so1629087gxk.19 for ; Sun, 30 Jan 2011 02:34:54 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1296134959.3622.37.camel@jlt3.sipsolutions.net> References: <1295816579-28925-1-git-send-email-arik@wizery.com> <1295816579-28925-3-git-send-email-arik@wizery.com> <1295868924.3639.2.camel@jlt3.sipsolutions.net> <1295950325.3650.5.camel@jlt3.sipsolutions.net> <1296030720.3635.14.camel@jlt3.sipsolutions.net> <1296134959.3622.37.camel@jlt3.sipsolutions.net> From: Arik Nemtsov Date: Sun, 30 Jan 2011 12:34:39 +0200 Message-ID: Subject: Re: [PATCH v2 2/6] nl80211: Pass probe response data to drivers To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Luciano Coelho , "John W. Linville" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Jan 27, 2011 at 15:29, Johannes Berg wrote: > On Wed, 2011-01-26 at 23:51 +0200, Arik Nemtsov wrote: >> On Wed, Jan 26, 2011 at 10:32, Johannes Berg wrote: >> > On Wed, 2011-01-26 at 08:00 +0200, Arik Nemtsov wrote: >> > >> >> >> > Why use a separate command for this, and not do it like the SSID? I also >> >> >> >> >> >> Its only relevant to AP-mode (at least for now) so bss_conf didn't >> >> >> seem appropriate. >> >> >> Also since its a dynamically allocated buffer it should be protected by RCU. >> >> > >> >> > But all that is unrelated to the nl80211 API, no? Also the SSID already >> >> > uses bss_conf too, and it's AP mode too... >> >> >> >> Do you have a preferred alternative? >> > >> > What's wrong with putting it in the same place as the SSID? >> >> Just put it as a pointer inside ieee80211_bss_conf? (It will still >> have to be RCU managed and all). >> About nl80211 API - I tried making it as similar as possible to the >> way the beacon works, but I guess I can pass it with bss_parameters as >> well. > > Wait, no, I don't get it -- what does the nl80211 API have to do with > how mac80211 manages it? I think for the nl80211 API the new command > doesn't make a whole lot of sense. What happens in mac80211 I don't > think matters much. I guess I misunderstood your original suggestion. Are you suggesting I put the probe resp as part of the NL80211_CMD_SET_BSS cmd? I'm ok with that. Arik