Return-path: Received: from mail-vx0-f174.google.com ([209.85.220.174]:52482 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501Ab1BOHIy convert rfc822-to-8bit (ORCPT ); Tue, 15 Feb 2011 02:08:54 -0500 Received: by vxb37 with SMTP id 37so3211633vxb.19 for ; Mon, 14 Feb 2011 23:08:53 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1297677974.3785.9.camel@jlt3.sipsolutions.net> References: <1297351797-35031-1-git-send-email-nbd@openwrt.org> <1297677974.3785.9.camel@jlt3.sipsolutions.net> From: "Luis R. Rodriguez" Date: Mon, 14 Feb 2011 23:08:32 -0800 Message-ID: Subject: Re: [PATCH 1/2] cfg80211: add a field for the bitrate of the last rx data packet from a station To: Johannes Berg Cc: Felix Fietkau , linux-wireless@vger.kernel.org, linville@tuxdriver.com Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Feb 14, 2011 at 2:06 AM, Johannes Berg wrote: > On Thu, 2011-02-10 at 16:29 +0100, Felix Fietkau wrote: >> Also fix a typo in the STATION_INFO_TX_BITRATE description >> >> Signed-off-by: Felix Fietkau >> --- >>  include/linux/nl80211.h |    3 ++ >>  include/net/cfg80211.h  |    5 +++- >>  net/wireless/nl80211.c  |   56 +++++++++++++++++++++++++++++++---------------- >>  3 files changed, 44 insertions(+), 20 deletions(-) >> >> diff --git a/include/linux/nl80211.h b/include/linux/nl80211.h >> index 821ffb9..35bfec2 100644 >> --- a/include/linux/nl80211.h >> +++ b/include/linux/nl80211.h >> @@ -1243,6 +1243,8 @@ enum nl80211_rate_info { >>   * @NL80211_STA_INFO_LLID: the station's mesh LLID >>   * @NL80211_STA_INFO_PLID: the station's mesh PLID >>   * @NL80211_STA_INFO_PLINK_STATE: peer link state for the station >> + * @NL80211_STA_INFO_RX_BITRATE: last unicast rx rate, nested attribute >> + *   containing info as possible, see &enum nl80211_sta_info_txrate. > > I think it would make sense to restrict this to data frames, as mgmt > frames will often be sent with a low rate. Would it be useful to show both? How about per AC? Luis