Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:37643 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753519Ab1BDBMM (ORCPT ); Thu, 3 Feb 2011 20:12:12 -0500 MIME-Version: 1.0 In-Reply-To: References: <201102032009.17100.rjw@sisk.pl> From: Linus Torvalds Date: Thu, 3 Feb 2011 17:11:14 -0800 Message-ID: Subject: Re: 2.6.38-rc3-git1: Reported regressions 2.6.36 -> 2.6.37 To: Keith Packard Cc: Dave Airlie , Carlos Mafra , Dave Airlie , "Rafael J. Wysocki" , Takashi Iwai , Linux Kernel Mailing List , Maciej Rutecki , Florian Mickler , Andrew Morton , Kernel Testers List , Network Development , Linux ACPI , Linux PM List , Linux SCSI List , Linux Wireless List , DRI Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Feb 3, 2011 at 5:05 PM, Keith Packard wrote: > > The goal is to make it so that when you *do* set a mode, DPMS gets set > to ON (as the monitor will actually be "on" at that point). Here's a > patch which does the DPMS_ON precisely when setting a mode. Ok, patch looks sane, but it does leave me with the "what about the 'fb_changed' case?" question. Is that case basically guaranteed to not change any existing dpms state? > (note, this patch compiles, but is otherwise only lightly tested). Carlos? Takashi? Ignore my crazy patch, try this one instead. Does it fix things for you? Linus