Subject: Re: [PATCH 01/15] staging: ath6kl: Fixing a NULL pointer exception
From: Joe Perches <joe@perches.com>
To: Greg KH <greg@kroah.com>
Cc: Vipin Mehta <vmehta@atheros.com>, linux-wireless@vger.kernel.org,
	devel@driverdev.osuosl.org
In-Reply-To: <20110218212938.GA21986@kroah.com>
References: <1298063596-2096-1-git-send-email-vmehta@atheros.com>
	 <20110218212938.GA21986@kroah.com>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 18 Feb 2011 13:56:40 -0800
Message-ID: <1298066200.7179.12.camel@Joe-Laptop>
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Fri, 2011-02-18 at 13:29 -0800, Greg KH wrote:
> On Fri, Feb 18, 2011 at 01:13:02PM -0800, Vipin Mehta wrote:
> > The driver was dereferencing a NULL pointer because of the device instance
> > being registered via the set_wiphy_dev() function. The function
> > ar6000_avail_ev() was passing the argument as NULL instead of using the one
> > returned by the MMC stack through the probe callback.
> I've applied all of these, but note that some of them add whitespace
> warnings.  In the future, I'll reject those that do this, please always
> run your patches through scripts/checkpatch.pl to not have this happen.

Vipin,

A good test is to generate the patches using git format-patch
then apply them to a new, separate branch using git am.
Whitespace problems will cause rejects.

You can use git am --whitespace=fix on each patch if necessary,
then regenerate the git format-patch set from that new branch.

cheers, Joe