Return-path: Received: from nbd.name ([46.4.11.11]:41632 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751787Ab1BDT0G (ORCPT ); Fri, 4 Feb 2011 14:26:06 -0500 Message-ID: <4D4C52CA.3030806@openwrt.org> Date: Fri, 04 Feb 2011 20:26:02 +0100 From: Felix Fietkau MIME-Version: 1.0 To: "Luis R. Rodriguez" CC: Mark Mentovai , linux-wireless@vger.kernel.org Subject: Re: [PATCH] cfg80211: fix maximum tx power handling References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2011-02-04 8:20 PM, Luis R. Rodriguez wrote: > On Sun, Jan 30, 2011 at 9:01 AM, Mark Mentovai wrote: >> I certainly like the idea of providing better feedback of the >> effective power level, or even the power level limit, back to users. >> This patch seems to artificially limit the effective power level in >> some cases, while allowing a value in excess of what would be >> appropriate in others. > > John, Mark's interpretation is correct, the exception here is accepted > because the driver request is being respected to override the max > regulatory power, nothing more. Felix are you observing userspace > requests overriding the orig power? What I'm observing is that with the first regdomain setting it sets orig_power to something that exceeds the tx power value that the hardware is capable of using. Because of that, the tx power setting reported to the user is wrong. - Felix