Return-path: Received: from nbd.name ([46.4.11.11]:54177 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753090Ab1BDV2y (ORCPT ); Fri, 4 Feb 2011 16:28:54 -0500 Message-ID: <4D4C6F94.2070709@openwrt.org> Date: Fri, 04 Feb 2011 22:28:52 +0100 From: Felix Fietkau MIME-Version: 1.0 To: Mark Mentovai CC: "Luis R. Rodriguez" , linux-wireless@vger.kernel.org Subject: Re: [PATCH] cfg80211: fix maximum tx power handling References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2011-02-04 9:19 PM, Mark Mentovai wrote: > That would work for ath9k. I still think it?d be prudent to examine a > handful of rates. I also seem to remember that some other values that > were being used within ath9k_init_txpower_limits were invalid. I think > ntxchains was invalid during that early phase of initialization, for > example. That might not have any ultimate effect on the result, but > it?s not right to hit that ath_debug claiming "Invalid chainmask > configuration" once for every supported channel every time the driver > initializes. I'll take a look at fixing all of that stuff soon, then we can go back to treating the driver's tx power values as a limit afterwards. - Felix