Return-path: Received: from 80-190-117-144.ip-home.de ([80.190.117.144]:49264 "EHLO bu3sch.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082Ab1BOAUL (ORCPT ); Mon, 14 Feb 2011 19:20:11 -0500 Subject: Re: [PATCH] ssb: Make ssb_wait_bit multi-bit safe From: Michael =?ISO-8859-1?Q?B=FCsch?= To: =?ISO-8859-1?Q?G=E1bor?= Stefanik Cc: John Linville , =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , b43-dev , linux-wireless In-Reply-To: (sfid-20110215_011145_942850_24C2EA9B) References: <1297725710.5683.17.camel@maggie> (sfid-20110215_011145_942850_24C2EA9B) Content-Type: text/plain; charset="UTF-8" Date: Tue, 15 Feb 2011 01:20:01 +0100 Message-ID: <1297729201.5683.22.camel@maggie> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2011-02-15 at 01:03 +0100, Gábor Stefanik wrote: > > -static int ssb_wait_bit(struct ssb_device *dev, u16 reg, u32 bitmask, > > - int timeout, int set) > > +static int ssb_wait_bits(struct ssb_device *dev, u16 reg, u32 bitmask, > > + int timeout, int set) > > While you are at it, you may want to change this to "bool set". Please feel free to submit a separate patch on top of this. -- Greetings Michael.