Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:45050 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753148Ab1BAOPN (ORCPT ); Tue, 1 Feb 2011 09:15:13 -0500 Date: Tue, 1 Feb 2011 09:05:39 -0500 From: "John W. Linville" To: Mohammed Shafi Cc: "Luis R. Rodriguez" , Mohammed Shajakhan , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH] ath9k: Fix memory leak due to failed PAPRD frames Message-ID: <20110201140538.GA2560@tuxdriver.com> References: <1296460529-13669-1-git-send-email-mshajakhan@atheros.com> <4D478F12.1070404@atheros.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4D478F12.1070404@atheros.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Feb 01, 2011 at 10:11:54AM +0530, Mohammed Shafi wrote: > On Tuesday 01 February 2011 12:13 AM, Luis R. Rodriguez wrote: > >On Sun, Jan 30, 2011 at 11:55 PM, Mohammed Shafi Shajakhan > > wrote: > >>From: Mohammed Shafi Shajakhan > >> > >>free the skb's when the Tx of PAPRD frames fails and also add a debug > >>message indicating that. > >> > >>Signed-off-by: Mohammed Shafi Shajakhan > >Is this a stable fix? > No Luis, this problem came from some recent changes in PAPRD before > that it was Ok. The patch applied to wireless-2.6 without changes, and the error handling for ath_tx_start matched existing usage. So, I have it queued now in wireless-2.6 with an added "Cc: stable@kernel.org". Should I not? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.