Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:50001 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752651Ab1BOIzK (ORCPT ); Tue, 15 Feb 2011 03:55:10 -0500 Subject: Re: [PATCH 1/2] cfg80211: add a field for the bitrate of the last rx data packet from a station From: Johannes Berg To: "Luis R. Rodriguez" Cc: Felix Fietkau , linux-wireless@vger.kernel.org, linville@tuxdriver.com In-Reply-To: References: <1297351797-35031-1-git-send-email-nbd@openwrt.org> <1297677974.3785.9.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Date: Tue, 15 Feb 2011 09:55:06 +0100 Message-ID: <1297760106.3935.0.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2011-02-14 at 23:08 -0800, Luis R. Rodriguez wrote: > On Mon, Feb 14, 2011 at 2:06 AM, Johannes Berg > wrote: > > On Thu, 2011-02-10 at 16:29 +0100, Felix Fietkau wrote: > >> Also fix a typo in the STATION_INFO_TX_BITRATE description > >> > >> Signed-off-by: Felix Fietkau > >> --- > >> include/linux/nl80211.h | 3 ++ > >> include/net/cfg80211.h | 5 +++- > >> net/wireless/nl80211.c | 56 +++++++++++++++++++++++++++++++---------------- > >> 3 files changed, 44 insertions(+), 20 deletions(-) > >> > >> diff --git a/include/linux/nl80211.h b/include/linux/nl80211.h > >> index 821ffb9..35bfec2 100644 > >> --- a/include/linux/nl80211.h > >> +++ b/include/linux/nl80211.h > >> @@ -1243,6 +1243,8 @@ enum nl80211_rate_info { > >> * @NL80211_STA_INFO_LLID: the station's mesh LLID > >> * @NL80211_STA_INFO_PLID: the station's mesh PLID > >> * @NL80211_STA_INFO_PLINK_STATE: peer link state for the station > >> + * @NL80211_STA_INFO_RX_BITRATE: last unicast rx rate, nested attribute > >> + * containing info as possible, see &enum nl80211_sta_info_txrate. > > > > I think it would make sense to restrict this to data frames, as mgmt > > frames will often be sent with a low rate. > > Would it be useful to show both? How about per AC? Why would anyone care about mgmt frames unless they're debugging something (in which case I recommend monitor interface)? And normally rate control shouldn't care about the AC so that seems pointless? johannes