Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:37814 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695Ab1B1Sb5 (ORCPT ); Mon, 28 Feb 2011 13:31:57 -0500 Message-ID: <4D6BEA16.2060604@lwfinger.net> Date: Mon, 28 Feb 2011 12:31:50 -0600 From: Larry Finger MIME-Version: 1.0 To: Alessio Igor Bogani , John Linville CC: Dan Carpenter , Chaoming Li , linux-wireless@vger.kernel.org, LKML , Tim Bird Subject: Re: [PATCH] rtlwifi: fix places where uninitialized data is used References: <20110228003734.GA9075@bicker> <1298880715-4286-1-git-send-email-abogani@kernel.org> In-Reply-To: <1298880715-4286-1-git-send-email-abogani@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 02/28/2011 02:11 AM, Alessio Igor Bogani wrote: > drivers/net/wireless/rtlwifi/rtl8192ce/trx.c: In function ‘rtl92ce_rx_query_desc’: > drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:255:5: warning: ‘rf_rx_num’ may be used uninitialized in this function > drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:257:12: warning: ‘total_rssi’ may be used uninitialized in this function > drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:466:6: warning: ‘weighting’ may be used uninitialized in this function > > This work was supported by a hardware donation from the CE Linux Forum. > > Signed-off-by: Alessio Igor Bogani > --- > drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c > index bf5852f..593eb8e 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c > @@ -252,9 +252,9 @@ static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw, > struct rtl_priv *rtlpriv = rtl_priv(hw); > struct phy_sts_cck_8192s_t *cck_buf; > s8 rx_pwr_all, rx_pwr[4]; > - u8 rf_rx_num, evm, pwdb_all; > + u8 evm, pwdb_all, rf_rx_num = 0; > u8 i, max_spatial_stream; > - u32 rssi, total_rssi; > + u32 rssi, total_rssi = 0; > bool is_cck_rate; > > is_cck_rate = RX_HAL_IS_CCK_RATE(pdesc); > @@ -463,7 +463,7 @@ static void _rtl92ce_update_rxsignalstatistics(struct ieee80211_hw *hw, > struct rtl_stats *pstats) > { > struct rtl_priv *rtlpriv = rtl_priv(hw); > - int weighting; > + int weighting = 0; > > if (rtlpriv->stats.recv_signal_power == 0) > rtlpriv->stats.recv_signal_power = pstats->recvsignalpower; ACK. Obviously gcc 4.5.1 has a bug and misses these, whereas 4.5.2 finds them. Larry