Return-path: Received: from kroah.org ([198.145.64.141]:53438 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863Ab1BDO4C (ORCPT ); Fri, 4 Feb 2011 09:56:02 -0500 Date: Fri, 4 Feb 2011 06:57:07 -0800 From: Greg KH To: "John W. Linville" Cc: "Luis R. Rodriguez" , Vivek Natarajan , linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/2] ath9k: Drain txq before sending a nullfunc frame. Message-ID: <20110204145707.GB11581@kroah.com> References: <1296800640-6381-1-git-send-email-vnatarajan@atheros.com> <20110204142130.GB2539@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110204142130.GB2539@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Feb 04, 2011 at 09:21:30AM -0500, John W. Linville wrote: > On Thu, Feb 03, 2011 at 11:36:27PM -0800, Luis R. Rodriguez wrote: > > Adding Greg for real this time. > > > > Luis > > > > On Thu, Feb 3, 2011 at 11:36 PM, Luis R. Rodriguez wrote: > > > On Thu, Feb 3, 2011 at 10:23 PM, Vivek Natarajan wrote: > > >> In a highly noisy environment, a data frame which is queued before > > >> a nullfunc frame on a different hw queue may be sent over the air > > >> after the tx completion of nullfunc frame. This causes the station > > >> to enter power save and the AP to see the station as awake and > > >> continues to send the data traffic. Fix this by draining all tx > > >> queues before we send the null function frame with PM bit set. > > >> > > >> Signed-off-by: Vivek Natarajan > > > > > > Hm nice, this is a good example of one of those random not-so-critical > > > but still nice fixes which I wish would go to stable. John, Greg, any > > > qualms for such things to go to stable if they apply? It was my > > > impression we could send it, but I want to verify with both you guys > > > so neither we or John get bashed if we try to send it as a stable fix. > > I think the feeling is that it is silly to mark something for stable if > it is not important enough to be sent as a fix for the current release. I totally agree. thanks, greg k-h