Return-path: Received: from mga11.intel.com ([192.55.52.93]:65191 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756117Ab1BYPqN (ORCPT ); Fri, 25 Feb 2011 10:46:13 -0500 Subject: Re: [PATCH 2/2] iwlagn: fix iwlagn_check_needed_chains From: "Guy, Wey-Yi" To: Johannes Berg Cc: John Linville , "linux-wireless@vger.kernel.org" , Daniel Halperin , Swati Rallapalli In-Reply-To: <1298648386.4329.18.camel@jlt3.sipsolutions.net> References: <20110225112409.977212647@sipsolutions.net> <20110225112620.515442527@sipsolutions.net> <1298648166.2603.11.camel@wwguy-ubuntu> <1298648386.4329.18.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Date: Fri, 25 Feb 2011 07:31:13 -0800 Message-ID: <1298647873.28351.10.camel@wwguy-huron> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2011-02-25 at 07:39 -0800, Johannes Berg wrote: > On Fri, 2011-02-25 at 07:36 -0800, wwguy wrote: > > > > @@ -503,7 +488,46 @@ static void iwlagn_check_needed_chains(s > > > * will soon tell us about that. > > > */ > > > need_multiple = false; > > > + rcu_read_unlock(); > > > + break; > > > > why unlock and break here instead stay do it later like before? > > Only because the indentation there was getting so deep it was annoying > to fit into 80 cols :-) how you want to submit this patch? through iwlagn, or yo uwill send it along with mac80211 to John? Wey >