Return-path: Received: from mail-qy0-f181.google.com ([209.85.216.181]:63864 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022Ab1BNTxH convert rfc822-to-8bit (ORCPT ); Mon, 14 Feb 2011 14:53:07 -0500 Received: by qyk12 with SMTP id 12so4184240qyk.19 for ; Mon, 14 Feb 2011 11:53:06 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1297282621.9734.5.camel@maggie> References: <1297282621.9734.5.camel@maggie> Date: Mon, 14 Feb 2011 20:51:54 +0100 Message-ID: Subject: Re: Notes on ssb specs and implementation From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: =?UTF-8?Q?Michael_B=C3=BCsch?= Cc: linux-wireless@vger.kernel.org, Larry Finger , b43-dev Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: W dniu 9 lutego 2011 21:17 użytkownik Michael Büsch napisał: > On Wed, 2011-02-09 at 21:00 +0100, Rafał Miłecki wrote: >> Michael: was there any reasons why we didn't implement some parts of >> core-disabling code? > > The function are complete as of latest reverse engineering efforts. > Broadcom added stuff, if they do more stuff in latest code. Nothing has changed in specs since 2006: http://bcm-v4.sipsolutions.net/Backplane?action=info For some reason routines that were present even in 2006 was not implemented. >> Michael: should we care about the way wl sets core specific flags? I >> didn't dig into that moment in MMIO dumps, but as ssb_device_enable >> implementation ignores flags at the end, it has to set flags somehow >> differently on it's own. > > I have no idea. ssb_device_enable is very hairy and I'm not going > to touch it without good reason and regression testing. > > You didn't tell us the important part: Does changing ssb_device_enable > make it work? I've just written missing parts, tested and it still does not work :| The only advantage discovered so far is that ssb detects sth is wrong with IM state: [ 2661.449647] ssb: Timeout waiting for bitmask 01800000 on register 0F90 to clear. I can see wl experiencing the same problems after loading b43. It reads 0xf90 dozen of times in a row. -- Rafał