Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:47385 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752853Ab1BBMDx (ORCPT ); Wed, 2 Feb 2011 07:03:53 -0500 Subject: Re: Support for Android for mac80211 / cfg80211 802.11 drivers From: Johannes Berg To: Bob Copeland Cc: Jouni Malinen , "Luis R. Rodriguez" , linux-wireless , linux-kernel@vger.kernel.org, Amod Bodas , Senthilkumar Balasubramanian , Sree Durbha , Deepak Dhamdhere , Xin Jin In-Reply-To: <20110202115743.GA12386@hash.localnet> References: <1296633772.3624.2.camel@jlt3.sipsolutions.net> <20110202113052.GA14126@jm.kir.nu> <20110202115743.GA12386@hash.localnet> Content-Type: text/plain; charset="UTF-8" Date: Wed, 02 Feb 2011 13:03:49 +0100 Message-ID: <1296648229.5671.2.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2011-02-02 at 06:57 -0500, Bob Copeland wrote: > On Wed, Feb 02, 2011 at 01:30:52PM +0200, Jouni Malinen wrote: > > If it is fine to remove the custom wpa_supplicant modifications from > > Android, this is obviously a moot point, but until that happens, the > > easiest approach seems to be to provide a custom driver_*.c based on > > nl80211 to isolate the custom changes to user space and to small part of > > it at that. I don't really want to see new drivers trying to provide > > WEXT support with private ioctls to address need for making it work with > > Android.. > > I guess my argument is if Atheros is spending resources on porting > drivers to Android, it would be nice to take the time to fix Android's > userspace too. At any rate, I disagree with the wiki's wording "the > proper approach" as opposed to maybe "the straight-forward approach." I couldn't let that sit there so I edited it ;-) > Android already has a custom userspace library that sits between wpa_s > and their Java stack where they could probably stick all of this stuff. > If there is something that is truly missing from the kernel, then by > all means we can add it to nl80211 for everyone's benefit. Right. But then stock wpa_s can also get it, and everybody is happy, no? johannes