Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:52080 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756Ab1C1MO2 (ORCPT ); Mon, 28 Mar 2011 08:14:28 -0400 Subject: Re: [PATCHv2] cfg80211: fix BSS double-unlinking (continued) From: Johannes Berg To: juuso.oikarinen@nokia.com Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org In-Reply-To: <1301311952-27659-1-git-send-email-juuso.oikarinen@nokia.com> References: <1301311952-27659-1-git-send-email-juuso.oikarinen@nokia.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 28 Mar 2011 14:14:23 +0200 Message-ID: <1301314463.8524.0.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2011-03-28 at 14:32 +0300, juuso.oikarinen@nokia.com wrote: > From: Juuso Oikarinen > > This patch adds to the fix "fix BSS double-unlinking" > (commit 3207390a8b58bfc1335750f91cf6783c48ca19ca) by Johannes Berg. > > It turns out, that the double-unlinking scenario can also occur if expired > BSS elements are removed whilst an interface is performing association. > > To work around that, replace list_del with list_del_init also in the > "cfg80211_bss_expire" function, so that the check for whether the BSS still is > in the list works correctly in cfg80211_unlink_bss. > > Signed-off-by: Juuso Oikarinen Reviewed-by: Johannes Berg Thanks. johannes