Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:33203 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751840Ab1CYUSJ (ORCPT ); Fri, 25 Mar 2011 16:18:09 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Ohad Ben-Cohen Date: Fri, 25 Mar 2011 22:17:43 +0200 Message-ID: Subject: Re: [PATCH v1 2/2] sdio: add power_restore support with MMC_PM_KEEP_POWER mode To: Wilson Loi Cc: linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org, akpm@linux-foundation.org, San Mehat , Roger Quadros , Nicolas Pitre , Gao Yunpeng Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Mar 25, 2011 at 7:08 PM, Wilson Loi wrote: > Therefore, there is a case that we power save for the host CPU and let the > firmware handle the wlan state. > WLAN card will wake up the host by SDIO IRQ or GPIO if there is a new > incoming packet later. Then you're talking about keeping the card powered during system suspend, which is already supported (as mentioned by Nicolas and Chris), but your patches really changed SDIO's runtime PM path (which is not needed since anyway the driver fully controls it).