Return-path: Received: from mail-gw0-f46.google.com ([74.125.83.46]:63779 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964909Ab1CaQEw (ORCPT ); Thu, 31 Mar 2011 12:04:52 -0400 MIME-Version: 1.0 In-Reply-To: <4D8FBE88.3050907@lwfinger.net> References: <1301174394-12642-1-git-send-email-wuzhangjin@gmail.com> <4D8E5BA3.1090909@users.sourceforge.net> <4D8E8B1E.3030709@users.sourceforge.net> <4D8FBE88.3050907@lwfinger.net> Date: Fri, 1 Apr 2011 00:04:50 +0800 Message-ID: Subject: Re: [RFC PATCH] rtl8187: Fix led support for rfkill From: wu zhangjin To: Larry Finger Cc: Hin-Tak Leung , Herton Ronaldo Krzesinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Roman Mamedov Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Mar 28, 2011 at 6:47 AM, Larry Finger wrote: [...] > > I think the commit message should be revised. A simple statement like "the > LED does not turn off when the rfkill switch is off" should be sufficient. Yeah, the above statement is simpler ;-) Regards, Wu Zhangjin > > Larry > >