Return-path: Received: from mail.atheros.com ([12.19.149.2]:37060 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032Ab1D2Ewo (ORCPT ); Fri, 29 Apr 2011 00:52:44 -0400 Received: from mail.atheros.com ([10.10.20.108]) by sidewinder.atheros.com for ; Thu, 28 Apr 2011 21:52:16 -0700 Message-ID: <4DBA4417.40604@atheros.com> (sfid-20110429_065246_760205_CB6B2712) Date: Fri, 29 Apr 2011 10:22:39 +0530 From: Mohammed Shafi MIME-Version: 1.0 To: "Luis R. Rodriguez" CC: Mohammed Shajakhan , "linux-wireless@vger.kernel.org" , "linville@tuxdriver.com" , Senthilkumar Balasubramanian Subject: Re: [RFC/RFT 0/9] ath9k: Add Antenna diversity support for AR9485 References: <1304000579-5784-1-git-send-email-mshajakhan@atheros.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thursday 28 April 2011 11:42 PM, Luis R. Rodriguez wrote: > On Thu, Apr 28, 2011 at 11:12 AM, Luis R. Rodriguez > wrote: > >> On Thu, Apr 28, 2011 at 7:22 AM, Mohammed Shafi Shajakhan >> wrote: >> >>> From: Mohammed Shafi Shajakhan >>> >>> *These are purely RFC/RFT patches, none of them are tested. >>> once tested we will send it as patches. >>> *This patch set adds Antenna diversity support for AR9485, previously >>> antenna diversity is only supported in AR9285 >>> *The basic antenna diversity algorithm remains the same >>> *slight change in the diversity field in eeprom >>> *introduction of main/alt gain table and lna1_lna2 delta fields >>> *initially set LNA1 for main antenna >>> *introduction of diversity group >>> *based on diversity group, fast diversity bias parmaters and >>> lna1_lna2_delta varies >>> *implement an API to take the decision of swapping main/ALT LNA's >>> for AR9485 >>> *configure fast diversity bias based on diversity group >>> >> Apart from my one comment: >> >> Reviewed-by: Luis R. Rodriguez >> > Oh yeah and great job on your patch split! > thanks! > Luis >