Return-path: Received: from mail.atheros.com ([12.19.149.2]:25333 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753775Ab1DEPEb (ORCPT ); Tue, 5 Apr 2011 11:04:31 -0400 Received: from mail.atheros.com ([10.10.20.105]) by sidewinder.atheros.com for ; Tue, 05 Apr 2011 08:04:06 -0700 Message-ID: <4D9B2F79.2090606@atheros.com> Date: Tue, 5 Apr 2011 20:34:25 +0530 From: Mohammed Shafi MIME-Version: 1.0 To: Felix Fietkau CC: Mohammed Shajakhan , "linux-wireless@vger.kernel.org" , "johannes@sipsolutions.net" Subject: Re: [RFC] mac80211: Add station uptime in debugfs References: <1302010795-2522-1-git-send-email-mshajakhan@atheros.com> <4D9B2268.8070902@openwrt.org> In-Reply-To: <4D9B2268.8070902@openwrt.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tuesday 05 April 2011 07:38 PM, Felix Fietkau wrote: > On 2011-04-05 3:39 PM, Mohammed Shafi Shajakhan wrote: > >> From: Mohammed Shafi Shajakhan >> >> Add station uptime parameter in debugfs. This will be helpful to get a >> measure of stability of connection and also during stress testing. >> >> Signed-off-by: Mohammed Shafi Shajakhan >> > >> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c >> index 999f8fb..08b9f51 100644 >> --- a/net/mac80211/sta_info.c >> +++ b/net/mac80211/sta_info.c >> @@ -244,6 +244,7 @@ struct sta_info *sta_info_alloc(struct ieee80211_sub_if_data *sdata, >> sta->local = local; >> sta->sdata = sdata; >> sta->last_rx = jiffies; >> + sta->sta_uptime = jiffies; >> >> ewma_init(&sta->avg_signal, 1024, 8); >> >> > I think jiffies can easily overflow. Maybe it would be better to get a > timeval from the monotonic clock. > Thanks, yes thats true and I assumed this will work fine for 49 days assuming 32 bit(please correct me if my calculations are wrong). will the overflow will take place in less than this time?. I will dig more into it by looking at the time val. > - Felix > . > >