Date: Tue, 19 Apr 2011 15:18:18 -0600 (MDT)
From: "Carl J. Richell" <carl@system76.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Message-ID: <22202847.17614.1303247898049.JavaMail.root@mail>
In-Reply-To: <4DADFAA0.7010205@lwfinger.net>
Subject: Re: rtlwifi: rtl8192ce: LED initialization
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Sender: linux-wireless-owner@vger.kernel.org

----- Original Message -----
> On 04/19/2011 02:57 PM, Carl J. Richell wrote:
> > Hi wireless developers,
> >
> > The patch at the following link fixes the wireless LED on rtl8192ce
> > devices.
> >
> > http://marc.info/?l=linux-wireless&m=130247823800466&w=2
> >
> > However, there is the following Error when compiling against 2.6.38
> > in Ubuntu natty:
> >
> > "
> > drivers/net/wireless/rtlwifi/rtl8192ce/led.c: In function
> > ‘_rtl92ce_init_led’:
> > drivers/net/wireless/rtlwifi/rtl8192ce/led.c:40:6: error: ‘struct
> > rtl_led’ has no member named ‘ledon’
> > make[5]: *** [drivers/net/wireless/rtlwifi/rtl8192ce/led.o] Error 1
> > "
> >
> > The driver compiles correctly and the LED works after commenting out
> > the offending line:
> >
> > wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/led.c
> >
> > static void _rtl92ce_init_led(struct ieee80211_hw *hw,
> > 			      struct rtl_led *pled, enum rtl_led_pin ledpin)
> > {
> > 	pled->hw = hw;
> > 	pled->ledpin = ledpin;
> > /* pled->ledon = false; */
> > }
> >
> > Is this an appropriate fix?
> 
> The patch was made for 2.6.39.
> 
> For 2.6.38, the routine _rtl92ce_init_led() does not exist, thus some
> of the
> other changes in rtl8192ce from .38 to .39 have been put into the
> driver, but
> not all. Your change should be OK.
> 

Thank you, Larry. Much appreciated!


Carl