Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:3815 "EHLO MMS3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753885Ab1DMIQw convert rfc822-to-8bit (ORCPT ); Wed, 13 Apr 2011 04:16:52 -0400 To: "George Kashperko" , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= cc: "balbi@ti.com" , "linux-wireless@vger.kernel.org" , "John W. Linville" , "b43-dev@lists.infradead.org" , =?utf-8?Q?Michael_B=C3=BCsch?= , "Larry Finger" , "linux-arm-kernel@lists.infradead.org" , "Russell King" , "Arnd Bergmann" , "Andy Botting" , linuxdriverproject , "linux-kernel@vger.kernel.org" Subject: Re: [RFC][PATCH] axi: add AXI bus driver References: <1302566227-23788-1-git-send-email-zajec5@gmail.com> <20110412133633.GR15130@legolas.emea.dhcp.ti.com> <1302634039.14216.10.camel@dev.znau.edu.ua> <1302635550.14216.21.camel@dev.znau.edu.ua> <4DA4AC4B.90409@hauke-m.de> <1302640546.14216.65.camel@dev.znau.edu.ua> Date: Wed, 13 Apr 2011 10:16:37 +0200 MIME-Version: 1.0 From: "Arend van Spriel" Message-ID: In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 12 Apr 2011 22:44:01 +0200, Rafał Miłecki wrote: > 2011/4/12 George Kashperko : >>> 2011/4/12 Rafał Miłecki : >>> That way I see really low (or not at all) relation between out >>> (not)Broadcom bus and present AMBA bus. >>> >> Agree. > > Ehh, sounds like one more renaming to functions, defines, prefixes. > > Let's wait for Arend comments, he was the one voting for > not-bcm-specific name. > Hi Rafał, Still think its better to stick with a generic name even if currently you only come across this in Broadcom chips right now. I do agree that the term 'axi' is implying something else than what this bus driver is providing. The name 'axi-dmp' I gave earlier may be more to the point. I also looked at the amba driver after receiving comments on the brcmaxi library module (this is what Hauke Mehrtens referred to) and came to similar conclusion as you did. It does however support PM properly so you may want to get inspiration in that area. I also noticed a reference to AMBA term APB which is a different bus in the AMBA family. AXI was introduced later as higher performance bus (in AMBA rev3 if I remember correctly). Gr. AvS -- "The world is indeed comic, but the joke is on mankind." — H.P. Lovecraft