Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:36154 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758438Ab1DNNGT (ORCPT ); Thu, 14 Apr 2011 09:06:19 -0400 Date: Thu, 14 Apr 2011 06:06:26 -0700 From: Mark Brown To: Antonio Ospite Cc: Johannes Berg , linux-wireless@vger.kernel.org, openezx-devel@lists.openezx.org, "John W . Linville" , linux-kernel@vger.kernel.org, Marek Vasut , Guiming Zhuo Subject: Re: [PATCH v3] rfkill: Regulator consumer driver for rfkill Message-ID: <20110414130626.GA7890@opensource.wolfsonmicro.com> References: <1302686356.3731.1.camel@jlt3.sipsolutions.net> <1302723645-5286-1-git-send-email-ospite@studenti.unina.it> <1302724383.3731.19.camel@jlt3.sipsolutions.net> <20110414123912.71e4bd52.ospite@studenti.unina.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110414123912.71e4bd52.ospite@studenti.unina.it> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Apr 14, 2011 at 12:39:12PM +0200, Antonio Ospite wrote: > Johannes Berg wrote: > > Should remove do platform_set_drvdata(pdev, NULL)? > AFAICS this is not strictly necessary because we never check for NULL > here and we are setting drvdata again in _probe() each time the module > is loaded anyways. If it is considered a good practice for symmetry > reasons then I'll add it, no problem. Does anyone has comments on that? We went round this loop with I2C - anything peering at driver data that it didn't originally set is buggy anyway so no need to reset to zero. If there was a need the platform bus or driver core should do it since all devices would need it.