Return-path: Received: from mail-qy0-f181.google.com ([209.85.216.181]:58661 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757687Ab1DHTqU convert rfc822-to-8bit (ORCPT ); Fri, 8 Apr 2011 15:46:20 -0400 MIME-Version: 1.0 In-Reply-To: <1302290881.1664.7.camel@Joe-Laptop> References: <1302291900-1902-1-git-send-email-zajec5@gmail.com> <1302290881.1664.7.camel@Joe-Laptop> Date: Fri, 8 Apr 2011 21:46:19 +0200 Message-ID: Subject: Re: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Joe Perches Cc: linux-wireless@vger.kernel.org, "John W. Linville" , George Kashperko , Arnd Bergmann , Russell King , "linux-kernel@vger.kernel.org" , b43-dev@lists.infradead.org, =?UTF-8?Q?Michael_B=C3=BCsch?= , linuxdriverproject , "linux-arm-kernel@lists.infradead.org" , Larry Finger Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2011/4/8 Joe Perches : > On Fri, 2011-04-08 at 21:45 +0200, Rafał Miłecki wrote: >> diff --git a/include/linux/axi/axi.h b/include/linux/axi/axi.h > [] >> +#define axi_info     pr_info >> +#ifdef CONFIG_AXI_DEBUG >> +#define axi_debug    pr_debug >> +#else >> +#define axi_debug    do { } while (0) >> +#endif >> +#define axi_err              pr_err > > I think redefining standard functionality like > this doesn't gain anything and loses some basic > grep capability. But on the other hand using: pr_info, pr_err, BUT axi_debug can easily lead to mistakes. Or is this possible to re-define pr_debug locally? -- Rafał