Return-path: Received: from mail-qy0-f174.google.com ([209.85.216.174]:60047 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751725Ab1DHQ4P convert rfc822-to-8bit (ORCPT ); Fri, 8 Apr 2011 12:56:15 -0400 MIME-Version: 1.0 In-Reply-To: References: <1302033463-1846-1-git-send-email-zajec5@gmail.com> Date: Fri, 8 Apr 2011 18:56:13 +0200 Message-ID: Subject: Re: [RFC][PATCH] bcmai: introduce AI driver From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Arend van Spriel Cc: "linux-wireless@vger.kernel.org" , "John W. Linville" , =?UTF-8?Q?Michael_B=C3=BCsch?= , Larry Finger , George Kashperko , "b43-dev@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , Russell King , Arnd Bergmann , linuxdriverproject , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2011/4/6 Arend van Spriel : > 3. Device identification > > The cores are identified by manufacturer, core id and revision in your > patch. I would not use the revision because 4 out of 5 times a revision > change does indicate a hardware change but no change in programming > interface. The enumeration data does contain a more selective field > indicating the core class (4 bits following the core identifier). I suggest > to replace the revision field by this class field. Could you say something more about *class*, please? For my BCM43224 it seems to be 0x0. WIll check BCM4313 in a moment. -- Rafał