Date: Fri, 6 May 2011 17:38:18 -0700
From: Greg KH <greg@kroah.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: akpm@linux-foundation.org, mingo@redhat.com, tglx@linutronix.de,
	hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org, allen.kao@atheros.com,
	roman.gezikov@atheros.com, joonas.viskari@atheros.com
Subject: Re: [RFC 0/2] x86: Add support for Atheros AR1520 GPS devices
Message-ID: <20110507003818.GA23997@kroah.com> (sfid-20110507_023843_663294_68958414)
References: <1304719780-27347-1-git-send-email-lrodriguez@atheros.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <1304719780-27347-1-git-send-email-lrodriguez@atheros.com>
Sender: linux-wireless-owner@vger.kernel.org

On Fri, May 06, 2011 at 03:09:38PM -0700, Luis R. Rodriguez wrote:
> These two patches adds support for the Atheros AR1520 GPS device,
> currently only pegged onto an mrst platform. This creates a character
> device called ar1520 and lets userspace talk to it through it. My only
> concern against this approach is that it this requires a custom userspace
> application for reseting the device, waking it up and for blocking reads
> through ioctl. The character device can be used to read/write data to it
> as well.

I really don't like using a character device for this, what's wrong with
a tty device instead like other GPS devices are using today (i.e. a
number of USB GPS devices)?

I don't understand what these ioctls are supposed to be doing, can't
they map to standard tty ioctls that we already have for flow control so
that userspace doesn't have to write a whole new application just to
talk to yet-another-gps-device?

thanks,

greg k-h