Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:52488 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752289Ab1EHKQj (ORCPT ); Sun, 8 May 2011 06:16:39 -0400 Date: Sun, 8 May 2011 11:16:09 +0100 From: Russell King - ARM Linux To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: George Kashperko , Arnd Bergmann , linux-wireless@vger.kernel.org, "John W. Linville" , b43-dev@lists.infradead.org, Greg KH , Michael =?iso-8859-1?Q?B=FCsch?= , Larry Finger , Arend van Spriel , linux-arm-kernel@lists.infradead.org, Andy Botting , linuxdriverproject , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver Message-ID: <20110508101609.GF27807@n2100.arm.linux.org.uk> (sfid-20110508_121645_038295_F54642DC) References: <1304632783-8781-1-git-send-email-zajec5@gmail.com> <201105061605.31625.arnd@arndb.de> <1304790665.13983.10.camel@dev.znau.edu.ua> <1304792795.13983.28.camel@dev.znau.edu.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, May 07, 2011 at 08:48:10PM +0200, Rafał Miłecki wrote: > Really, what's wrong with that? Does it kill anyone's pet we print > this? We also do: > pr_err("Scanning failed because of wrong CID\n"); > return -1; > While we could drop pr_err. Why to do this? Advanced used can always > check what -1 means. And why return -1 when we have a system of error codes? I _really_ wish people would stop returning -1 for "some random error occurred".