Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:47046 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932223Ab1EWTqa (ORCPT ); Mon, 23 May 2011 15:46:30 -0400 Received: by vws1 with SMTP id 1so4384949vws.19 for ; Mon, 23 May 2011 12:46:29 -0700 (PDT) Message-ID: <4DDAB992.1050006@lwfinger.net> (sfid-20110523_214633_795889_9B05CB52) Date: Mon, 23 May 2011 14:46:26 -0500 From: Larry Finger MIME-Version: 1.0 To: Mike McCormack CC: chaoming_li@realsil.com.cn, linville@tuxdriver.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH 2/8] rtlwifi: Remove set_rfpowerstate_inprogress References: <4DDA66F0.5000803@ring3k.org> In-Reply-To: <4DDA66F0.5000803@ring3k.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 05/23/2011 08:53 AM, Mike McCormack wrote: > set_rfpowerstate_inprogress is only set and never read > so remove it. > > Signed-off-by: Mike McCormack > --- > drivers/net/wireless/rtlwifi/rtl8192ce/phy.c | 2 -- > drivers/net/wireless/rtlwifi/rtl8192cu/phy.c | 2 -- > drivers/net/wireless/rtlwifi/rtl8192se/phy.c | 4 ---- > drivers/net/wireless/rtlwifi/wifi.h | 1 - > 4 files changed, 0 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c b/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c > index abe0fcc..544e0b7 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c > @@ -521,7 +521,6 @@ static bool _rtl92ce_phy_set_rf_power_state(struct ieee80211_hw *hw, > u8 i, queue_id; > struct rtl8192_tx_ring *ring = NULL; > > - ppsc->set_rfpowerstate_inprogress = true; > switch (rfpwr_state) { > case ERFON:{ > if ((ppsc->rfpwr_state == ERFOFF)&& > @@ -617,7 +616,6 @@ static bool _rtl92ce_phy_set_rf_power_state(struct ieee80211_hw *hw, > } > if (bresult) > ppsc->rfpwr_state = rfpwr_state; > - ppsc->set_rfpowerstate_inprogress = false; > return bresult; > } > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c b/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c > index 9a3d023..7285290 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c > @@ -470,7 +470,6 @@ static bool _rtl92cu_phy_set_rf_power_state(struct ieee80211_hw *hw, > u8 i, queue_id; > struct rtl8192_tx_ring *ring = NULL; > > - ppsc->set_rfpowerstate_inprogress = true; > switch (rfpwr_state) { > case ERFON: > if ((ppsc->rfpwr_state == ERFOFF)&& > @@ -590,7 +589,6 @@ static bool _rtl92cu_phy_set_rf_power_state(struct ieee80211_hw *hw, > } > if (bresult) > ppsc->rfpwr_state = rfpwr_state; > - ppsc->set_rfpowerstate_inprogress = false; > return bresult; > } > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/phy.c b/drivers/net/wireless/rtlwifi/rtl8192se/phy.c > index 63b45e6..2ad51b0 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192se/phy.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192se/phy.c > @@ -546,8 +546,6 @@ bool rtl92s_phy_set_rf_power_state(struct ieee80211_hw *hw, > if (rfpwr_state == ppsc->rfpwr_state) > return false; > > - ppsc->set_rfpowerstate_inprogress = true; > - > switch (rfpwr_state) { > case ERFON:{ > if ((ppsc->rfpwr_state == ERFOFF)&& > @@ -659,8 +657,6 @@ bool rtl92s_phy_set_rf_power_state(struct ieee80211_hw *hw, > if (bresult) > ppsc->rfpwr_state = rfpwr_state; > > - ppsc->set_rfpowerstate_inprogress = false; > - > return bresult; > } > > diff --git a/drivers/net/wireless/rtlwifi/wifi.h b/drivers/net/wireless/rtlwifi/wifi.h > index 693395e..0321328 100644 > --- a/drivers/net/wireless/rtlwifi/wifi.h > +++ b/drivers/net/wireless/rtlwifi/wifi.h > @@ -1188,7 +1188,6 @@ struct rtl_efuse { > > struct rtl_ps_ctl { > bool pwrdomain_protect; > - bool set_rfpowerstate_inprogress; > bool in_powersavemode; > bool rfchange_inprogress; > bool swrf_processing; Signed-off-by: Larry Finger --- Larry