Return-path: Received: from oproxy6-pub.bluehost.com ([67.222.54.6]:35346 "HELO oproxy6-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757434Ab1EKRAd (ORCPT ); Wed, 11 May 2011 13:00:33 -0400 Date: Wed, 11 May 2011 10:00:30 -0700 From: Randy Dunlap To: Sascha Silbe Cc: linux-wireless@vger.kernel.org, devel@lists.laptop.org, Dan Williams , "John W. Linville" , libertas-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Add libertas_disablemesh module parameter to disable mesh interface Message-Id: <20110511100030.cad34893.rdunlap@xenotime.net> (sfid-20110511_190100_927337_8EFA5F0A) In-Reply-To: <1305118354-17337-1-git-send-email-silbe@activitycentral.com> References: <1305118354-17337-1-git-send-email-silbe@activitycentral.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 11 May 2011 14:52:34 +0200 Sascha Silbe wrote: > This allows individual users and deployments to disable mesh support at > runtime, i.e. without having to build and maintain a custom kernel. I guess a user could want to do this on a per-driver basis, but ISTM that it would be better to be something like a sysctl that applies to all (wireless) drivers. Do other wireless drivers have something like this? > Based on a patch by Paul Fox . > Signed-off-by: Sascha Silbe > --- > drivers/net/wireless/libertas/main.c | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > > The patch is based on the OLPC 2.6.35 kernel tree, but applies cleanly to > wireless-next. > > diff --git a/drivers/net/wireless/libertas/main.c b/drivers/net/wireless/libertas/main.c > index 8445473..62069e2 100644 > --- a/drivers/net/wireless/libertas/main.c > +++ b/drivers/net/wireless/libertas/main.c > @@ -41,6 +41,10 @@ unsigned int lbs_debug; > EXPORT_SYMBOL_GPL(lbs_debug); > module_param_named(libertas_debug, lbs_debug, int, 0644); > > +unsigned int lbs_disablemesh; > +EXPORT_SYMBOL_GPL(lbs_disablemesh); > +module_param_named(libertas_disablemesh, lbs_disablemesh, int, 0644); > + > > /* This global structure is used to send the confirm_sleep command as > * fast as possible down to the firmware. */ > @@ -1086,7 +1090,10 @@ int lbs_start_card(struct lbs_private *priv) > > lbs_update_channel(priv); > > - lbs_init_mesh(priv); > + if (!lbs_disablemesh) > + lbs_init_mesh(priv); > + else > + lbs_pr_info("%s: mesh disabled\n", dev->name); > > /* > * While rtap isn't related to mesh, only mesh-enabled > -- --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***