Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:52982 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752896Ab1EIQCX (ORCPT ); Mon, 9 May 2011 12:02:23 -0400 Message-ID: <4DC81009.5060501@lwfinger.net> (sfid-20110509_180322_636405_29C16797) Date: Mon, 09 May 2011 11:02:17 -0500 From: Larry Finger MIME-Version: 1.0 To: Joe Perches CC: Chaoming Li , "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, LKML Subject: Re: [PATCH] rtlwifi: rtl8192cu: Fix memset using sizeof(ptr) not sizeof(*ptr) References: <1304919832.19586.15.camel@Joe-Laptop> In-Reply-To: <1304919832.19586.15.camel@Joe-Laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 05/09/2011 12:43 AM, Joe Perches wrote: > Found via coccinelle script > > @@ > type T; > T* ptr; > expression E1; > @@ > > * memset(E1, 0, sizeof(ptr)); > > Signed-off-by: Joe Perches > --- > drivers/net/wireless/rtlwifi/rtl8192cu/trx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c > index 79c98f6..c16fc1c 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/trx.c > @@ -372,7 +372,7 @@ static void _rtl_rx_process(struct ieee80211_hw *hw, struct sk_buff *skb) > __le16 fc; > struct ieee80211_hdr *hdr; > > - memset(rx_status, 0, sizeof(rx_status)); > + memset(rx_status, 0, sizeof(*rx_status)); > rxdesc = skb->data; > skb_len = skb->len; > drvinfo_len = (GET_RX_DESC_DRVINFO_SIZE(rxdesc) * RTL_RX_DRV_INFO_UNIT); ACK. Larry