Return-path: Received: from nbd.name ([46.4.11.11]:35800 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751964Ab1EEVy1 (ORCPT ); Thu, 5 May 2011 17:54:27 -0400 Message-ID: <4DC31C91.1030303@openwrt.org> (sfid-20110505_235430_834290_C4F4E5B9) Date: Thu, 05 May 2011 23:54:25 +0200 From: Felix Fietkau MIME-Version: 1.0 To: Ben Greear CC: "linux-wireless@vger.kernel.org" Subject: Re: Bisected: ath9k: fix powersave frame filtering/buffering in AP mode broke STA association. References: <4DC30C42.6070402@candelatech.com> <4DC3109F.6080601@openwrt.org> <4DC3135C.4040601@candelatech.com> <4DC31A0B.4040409@candelatech.com> In-Reply-To: <4DC31A0B.4040409@candelatech.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2011-05-05 11:43 PM, Ben Greear wrote: > On 05/05/2011 02:15 PM, Ben Greear wrote: >> On 05/05/2011 02:03 PM, Felix Fietkau wrote: >>> On 2011-05-05 10:44 PM, Ben Greear wrote: >>>> I bisected the problem I was having with ath9k STA configured for WPA >>>> not being able to authenticate. I'm using nohwcrypt=1, which may >>>> be why no one else sees it. >> >>>> I'll be happy to test patches, it seems very easy to reproduce on >>>> my setup. >>> How about this? >>> >>> --- a/net/mac80211/tx.c >>> +++ b/net/mac80211/tx.c >>> @@ -1270,6 +1270,9 @@ ieee80211_tx_prepare(struct ieee80211_su >>> info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT; >>> else if (test_and_clear_sta_flags(tx->sta, WLAN_STA_CLEAR_PS_FILT)) >>> info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT; >>> + else if (sdata->vif.type != NL80211_IFTYPE_AP&& >>> + sdata->vif.type != NL80211_IFTYPE_AP_VLAN) >>> + info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT; >>> >>> hdrlen = ieee80211_hdrlen(hdr->frame_control); >>> if (skb->len> hdrlen + sizeof(rfc1042_header) + 2) { >> >> Yes, that seems to fix the problem. >> >> Thanks for the quick fix! > > Well, that appeared to fix the problem on -rc1, but when I go > back to -rc6 and apply that patch, it still doesn't work. > > Might be some other issue though... Odd. Please try bisecting by applying the patch for each test and reverting it before running git bisect again. > Are you able to get STA to associate& athenticate on latest wireless-testing? I'll try it by making a new wireless-testing based compat-wireless. - Felix