Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:37015 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757086Ab1EMHPt (ORCPT ); Fri, 13 May 2011 03:15:49 -0400 Subject: Re: [PATCH v2] net: rfkill: add generic gpio rfkill driver From: Johannes Berg To: Rhyland Klein Cc: "olof@lixom.net" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" In-Reply-To: <1305235386.10961.13.camel@rklein-linux2> References: <1305159661-11982-1-git-send-email-rklein@nvidia.com> <1305189092.3461.10.camel@jlt3.sipsolutions.net> <1305224592.10961.10.camel@rklein-linux2> <1305225648.3461.37.camel@jlt3.sipsolutions.net> <1305226377.10961.12.camel@rklein-linux2> <1305226969.3461.38.camel@jlt3.sipsolutions.net> <1305235386.10961.13.camel@rklein-linux2> Content-Type: text/plain; charset="UTF-8" Date: Fri, 13 May 2011 09:15:43 +0200 Message-ID: <1305270943.3487.5.camel@jlt3.sipsolutions.net> (sfid-20110513_091606_877405_8DAFD043) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2011-05-12 at 14:23 -0700, Rhyland Klein wrote: > On Thu, 2011-05-12 at 12:02 -0700, Johannes Berg wrote: > > On Thu, 2011-05-12 at 11:52 -0700, Rhyland Klein wrote: > > > > > > If, on the other hand, rfkill decides that at the time of loading the > > > > driver wifi should be on, then the first change would be +1 and it'll > > > > flip between 0 and +1. > > > > > > > > This seems like it'll cause issues at some point, so I think you should > > > > either allow the driver to set the initial state or hardcode one of > > > > these possibilities (so at least it's predictable) > > > > > I won't go negative, if you look, it only will disable clock if it knows > > > it has already enabled it. > > > > Ah, you're right, I misread the macros. > So the patch is good as is? I think so, yes. johannes