Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:4691 "EHLO MMS3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361Ab1EHInn convert rfc822-to-8bit (ORCPT ); Sun, 8 May 2011 04:43:43 -0400 Message-ID: <4DC657A4.7020800@broadcom.com> (sfid-20110508_104356_031187_1566C9A8) Date: Sun, 8 May 2011 10:43:16 +0200 From: "Arend van Spriel" MIME-Version: 1.0 To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= cc: "George Kashperko" , "Arnd Bergmann" , "linux-wireless@vger.kernel.org" , "John W. Linville" , "b43-dev@lists.infradead.org" , "Greg KH" , =?UTF-8?B?TWljaGFlbCBCw7xzY2g=?= , "Larry Finger" , "linux-arm-kernel@lists.infradead.org" , "Russell King" , "Andy Botting" , linuxdriverproject , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver References: <1304632783-8781-1-git-send-email-zajec5@gmail.com> <201105061605.31625.arnd@arndb.de> <1304790665.13983.10.camel@dev.znau.edu.ua> <1304792795.13983.28.camel@dev.znau.edu.ua> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 05/07/2011 08:48 PM, Rafał Miłecki wrote: > 2011/5/7 George Kashperko: >> I guess core id 0x800 by 0x04BF vendor and 0x800 by 0x043B vendor will >> both be reported as ChipCommon which most likely is wrong for second >> one. Btw, ChipCommon is 0x500 for 4706 and there will be more new core >> codes for new Broadcom devices. Don't think its right to build core >> names database into kernel while there will be at most few of them used >> on particular end system. > This is constructive, I'll fix this, thanks. Hi Rafał, Late response, but I tried to tell what George clarified by the example above so you need nested switch. I tend to agree with George that having this id to name conversion in the bus driver may be nice for debugging, but apart from memory usage it also gives you additional maintenance work. Leave it up to you. Gr. AvS