Return-path: Received: from mail.perches.com ([173.55.12.10]:2313 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752153Ab1E2Ukr (ORCPT ); Sun, 29 May 2011 16:40:47 -0400 Subject: Re: [PATCH 2/4] staging: Remove direct includes of printk.h From: Joe Perches To: julie Sullivan Cc: Geert Uytterhoeven , Randy Dunlap , devel@driverdev.osuosl.org, Dowan Kim , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Sun, 29 May 2011 13:40:45 -0700 Message-ID: <1306701645.14524.3.camel@Joe-Laptop> (sfid-20110529_224104_549486_EF6B1B06) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, 2011-05-29 at 18:00 +0100, julie Sullivan wrote: > > --- a/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c [] > types.h is also a subfile of kernel.h, right? Yes it is. > Or maybe you patched this one already - if so please excuse the noise :-) No I didn't patch that one. I think it wouldn't be good to do that. printk.h may be a special case because it was moved out of kernel.h just to make it a bit neater. You are welcome to if you choose to. There are like 1500 or so files that have both kernel.h and types.h $ grep --include=*.[ch] -rP -l "^\s*\#\s*include\s+\" * | \ xargs grep -Pl "^\s*\#\s*include\s+\" | wc -l 1572