Return-path: Received: from mail-qy0-f181.google.com ([209.85.216.181]:60844 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567Ab1EHRLo convert rfc822-to-8bit (ORCPT ); Sun, 8 May 2011 13:11:44 -0400 Received: by qyg14 with SMTP id 14so3521869qyg.19 for ; Sun, 08 May 2011 10:11:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4DC6CD8C.6080104@lwfinger.net> References: <1304874564-6426-1-git-send-email-zajec5@gmail.com> <4DC6CD8C.6080104@lwfinger.net> Date: Sun, 8 May 2011 19:11:44 +0200 Message-ID: (sfid-20110508_191151_903175_62392A4A) Subject: Re: [PATCH 0/3] ssb/b43(legacy): clean dangling cores workarounds From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Larry Finger Cc: linux-wireless@vger.kernel.org, "John W. Linville" , =?UTF-8?Q?Michael_B=C3=BCsch?= , b43-dev@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2011/5/8 Larry Finger : > On 05/08/2011 12:09 PM, Rafał Miłecki wrote: >> >> There is no perfect place for this workarounds, but keeping it in ssb >> sounds >> more reasonable. >> 1) We already have in ssb similar workarounds for different cores >> 2) We do not register not working devices in system >> 3) We do not duplicate code in b43 and b43legacy >> >> Rafał Miłecki (3): >>   ssb: update list of devices supporting multiple 80211 cores >>   b43: drop ssb-duplicated workaround for dangling cores >>   b43legacy: drop ssb-duplicated workaround for dangling cores >> >>  drivers/net/wireless/b43/main.c       |   17 ----------------- >>  drivers/net/wireless/b43legacy/main.c |   18 ------------------ >>  drivers/ssb/scan.c                    |    5 ++++- >>  3 files changed, 4 insertions(+), 36 deletions(-) > > First of all, a minor grammatical mistake. It should be "this workaround" as > there is only only one workaround discussed here. > > Secondly, "we do not register not working" is a little awkward. "We do not > register inactive devices..." would be better. > > Finally, this commit message will never show up in the git commit logs. I > think this info is valuable, thus it should be in the real commits. > > My suggestion for the [1/3] patch is something like: > > "Many of the BCM43xx chips contain cores that are attached to the SSB, but > are inactive as they do not connect to the external environment. These must > not be registered. Several of these types are handled in driver ssb; > however, the specific case of an inactive 802.11 cores is now treated in b43 > and b43legacy. Although the current setup works, this minor change will > place all such workarounds in ssb, and simplify the code in drivers b43 and > b43legacy." > > In each of the other two patches, add a commit message something like: > > "Remove the code to detect inactive 802.11 cores, as that function is now > done in ssb." Thank you for reviewing. > I have not yet tested the patches, but will do so soon. Oh, do you have some device with 2 active cores? Nice :) -- Rafał