Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from mail.perches.com ([173.55.12.10]:1765 "EHLO mail.perches.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752871Ab1ESAcp (ORCPT <rfc822;linux-wireless@vger.kernel.org>);
	Wed, 18 May 2011 20:32:45 -0400
Subject: Re: [PATCH] staging: brcm80211: brcmfmac: Add and use dhd_dbg
From: Joe Perches <joe@perches.com>
To: Henry Ptasinski <henryp@broadcom.com>
Cc: Brett Rudley <brudley@broadcom.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	Dowan Kim <dowan@broadcom.com>,
	Roland Vossen <rvossen@broadcom.com>,
	Arend Van Spriel <arend@broadcom.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Franky (Zhenhui) Lin" <frankyl@broadcom.com>
In-Reply-To: <4DD44C21.1080502@broadcom.com>
References: <60c19c2ad4f078b6f283b5ff4ecca3653833ea28.1305742868.git.joe@perches.com>
	 <4DD44C21.1080502@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 18 May 2011 17:32:43 -0700
Message-ID: <1305765163.1745.4.camel@Joe-Laptop> (sfid-20110519_023301_469904_C4CE4425)
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

On Wed, 2011-05-18 at 15:45 -0700, Henry Ptasinski wrote:
> On 05/18/2011 11:23 AM, Joe Perches wrote:
> > All uses of DHD_<TYPE>  macros are for debugging only.
> > Change the multiple uses of DHD_<TYPE>((...)) to dhd_dbg(TYPE, ...)
> > for a more consistent style.
> I generally like this approach, but in brcmsmac we've been switching to 
> wiphy_err() and related instead.  Any strong argument for one over the 
> other?

These aren't described as errors but are debugging messages.
 
> > -       DHD_TRACE(("%s: Enter\n", __func__));
> > +       dhd_dbg(TRACE, "%s: Enter\n", __func__);
> I'd propose moving __func__ into the macro definition itself, which 
> would help ensure consistency (and shorten all the debug lines a bit).

I think TRACE is unnecessary and can be eliminated
and replaced by the function tracer.

Not all uses use __func__.
I think __func__ unnecessary and it should be avoided.

Other than that, I've no objections.

> Also, perhaps rename to "brcm_dbg()", "bcm_dbg()" or something like that 
> and move it into include/bcmutils.h, so brcmsmac can use it as well.

Your choice.