Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:37284 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932638Ab1FABGT convert rfc822-to-8bit (ORCPT ); Tue, 31 May 2011 21:06:19 -0400 Received: by bwz15 with SMTP id 15so4123262bwz.19 for ; Tue, 31 May 2011 18:06:18 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1306870643-7935-1-git-send-email-juhosg@openwrt.org> From: Daniel Halperin Date: Tue, 31 May 2011 18:05:58 -0700 Message-ID: (sfid-20110601_030623_308801_92B17D13) Subject: Re: [RFC 00/32] ath9k: add initial support for AR9330 To: Adrian Chadd Cc: Gabor Juhos , "John W. Linville" , linux-wireless@vger.kernel.org, Luis Rodriguez , Vasanthakumar Thiagarajan Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, May 31, 2011 at 5:46 PM, Adrian Chadd wrote: > Hi, > > On 1 June 2011 03:51, Daniel Halperin wrote: >> On Tue, May 31, 2011 at 12:36 PM, Gabor Juhos wrote: >>> It is a 1x1 chip and supports 2.4GHz only. >> >> [snip] >> >>> ?ath9k: enable antenna diversity for AR9330 >> >> I'm confused by the combination of these two. > > I bet it's like the AR9285 - there's one TX and one RX chain, but two > RX inputs, two LNAs and some controllable bits to determine how the > baseband controls how the LNAs are configured/combined for packet RX. > > For clarity (heh), see the diversity combining code in recv.c; it > outlines the various LNA combination modes. Gotcha. I was under the impression that Atheros has historically marketed these (misleadingly) as '1x2' devices, e.g., see the '3x3' devices that have 3 antennas but only 2 chains. Dan