Return-path: Received: from que31.charter.net ([209.225.8.23]:46893 "EHLO que31.charter.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751752Ab1FMOvR (ORCPT ); Mon, 13 Jun 2011 10:51:17 -0400 Message-ID: <4DF61E7E.908@cuw.edu> (sfid-20110613_165123_535900_CD05F2E1) Date: Mon, 13 Jun 2011 09:28:14 -0500 From: Greg Dietsche MIME-Version: 1.0 To: sgruszka@redhat.com, linville@tuxdriver.com CC: Greg Dietsche , kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] iwlegacy: remove unreachable code References: <1307066770-27309-1-git-send-email-Gregory.Dietsche@cuw.edu> In-Reply-To: <1307066770-27309-1-git-send-email-Gregory.Dietsche@cuw.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/02/2011 09:06 PM, Greg Dietsche wrote: > return; at the end of the function is unecessary. > > Signed-off-by: Greg Dietsche > --- > drivers/net/wireless/iwlegacy/iwl-eeprom.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/iwlegacy/iwl-eeprom.c b/drivers/net/wireless/iwlegacy/iwl-eeprom.c > index cb346d1..5bf3f49 100644 > --- a/drivers/net/wireless/iwlegacy/iwl-eeprom.c > +++ b/drivers/net/wireless/iwlegacy/iwl-eeprom.c > @@ -316,7 +316,6 @@ static void iwl_legacy_init_band_reference(const struct iwl_priv *priv, > break; > default: > BUG(); > - return; > } > } > > any comments/reviews/acks on this patch series? thanks, Greg