Return-path: Received: from nbd.name ([46.4.11.11]:48929 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161903Ab1FAMsz (ORCPT ); Wed, 1 Jun 2011 08:48:55 -0400 Message-ID: <4DE63533.9090709@openwrt.org> (sfid-20110601_144913_265003_BB9F5BBE) Date: Wed, 01 Jun 2011 14:48:51 +0200 From: Felix Fietkau MIME-Version: 1.0 To: Johannes Berg CC: linux-wireless@vger.kernel.org, linville@tuxdriver.com Subject: Re: [PATCH 2/3] mac80211: create a STA entry for a WDS interface after receiving a beacon References: <1306869394-83047-1-git-send-email-nbd@openwrt.org> <1306869394-83047-2-git-send-email-nbd@openwrt.org> <1306870354.29989.1.camel@jlt3.sipsolutions.net> <4DE543E2.9070600@openwrt.org> <1306872395.29989.3.camel@jlt3.sipsolutions.net> <4DE54E16.7000709@openwrt.org> <1306901843.3867.2.camel@jlt3.sipsolutions.net> <4DE61A11.1070708@openwrt.org> <1306926131.3867.8.camel@jlt3.sipsolutions.net> <4DE61FEA.60903@openwrt.org> <1306927838.3867.10.camel@jlt3.sipsolutions.net> <4DE6256B.80106@openwrt.org> <1306931187.3867.11.camel@jlt3.sipsolutions.net> In-Reply-To: <1306931187.3867.11.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2011-06-01 2:26 PM, Johannes Berg wrote: > On Wed, 2011-06-01 at 13:41 +0200, Felix Fietkau wrote: >> On 2011-06-01 1:30 PM, Johannes Berg wrote: >> > On Wed, 2011-06-01 at 13:18 +0200, Felix Fietkau wrote: >> > >> >> >> >> >> > I don't understand how you can rely on beacons for WDS. >> > >> >> Oh, right. I'll send a follow-up patch that forces a WDS to also have an >> >> active AP interface before it's brought up. >> > >> > Hm, that might be sufficient, but what if the peer isn't sending >> > beacons? >> > >> > Can't we add a station entry and then update it if we receive >> > information from the peer? That'd be more compatible with others devices >> > that don't necessarily have beacons with WDS, and then we wouldn't have >> > to require it locally either (since realistically we might have to >> > interoperate with those anyway?) >> What other devices use WDS without beacons? So far I haven't seen any. > > I don't know, at least older mac80211 could do that? In older mac80211 (at least the versions that I tested), WDS was completely broken. It also created the station entry without any valid rates, and it had no means of updating the supported rates list. - Felix