Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:45729 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753035Ab1FFLAa convert rfc822-to-8bit (ORCPT ); Mon, 6 Jun 2011 07:00:30 -0400 Received: by qwk3 with SMTP id 3so1585652qwk.19 for ; Mon, 06 Jun 2011 04:00:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4DECB232.70308@broadcom.com> References: <1307311658-15853-1-git-send-email-hauke@hauke-m.de> <1307311658-15853-4-git-send-email-hauke@hauke-m.de> <1307356322.28734.11.camel@dev.znau.edu.ua> <4DECB232.70308@broadcom.com> Date: Mon, 6 Jun 2011 13:00:29 +0200 Message-ID: (sfid-20110606_130033_177971_4A510D4E) Subject: Re: [RFC][PATCH 03/10] bcma: add embedded bus From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Arend van Spriel Cc: George Kashperko , Hauke Mehrtens , "linux-wireless@vger.kernel.org" , "linux-mips@linux-mips.org" , "mb@bu3sch.de" , "b43-dev@lists.infradead.org" , "bernhardloos@googlemail.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: W dniu 6 czerwca 2011 12:55 użytkownik Arend van Spriel napisał: > On 06/06/2011 12:51 PM, Rafał Miłecki wrote: >> >> W dniu 6 czerwca 2011 12:32 użytkownik George Kashperko >>  napisał: >>> >>> Hi, >>> >>>> Hauke, >>>> >>>> My idea for naming schema was to use: >>>> bcma_host_TYPE_* >>>> >>>> Like: >>>> bcma_host_pci_* >>>> bcma_host_sdio_* >>>> >>>> You are using: >>>> bcma_host_bcma_* >>>> >>>> What do you think about changing this to: >>>> bcma_host_embedded_* >>>> or just some: >>>> bcma_host_emb_* >>>> ? >>>> >>>> Does it make more sense to you? I was trying to keep names in bcma >>>> really clear, so every first-time-reader can see differences between >>>> hosts, host and driver, etc. >>> >>> how about bcma_host_soc ? >> >> We get then inconsistency with "BCMA_HOSTTYPE_EMBEDDED". I'd like to >> 1) See something like bcma_host_emb... >> xor >> 2) Use bcma_host_soc_* and BCMA_HOSTTYPE_SOC >> > > I would go for option 2). It more clearly says what it is. Embedded is a > broader term. As an example, a handset is an embedded device, but it may use > BCMA_HOSTTYPE_SDIO. Good point, agree. -- Rafał