Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:36090 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932665Ab1FAAqv convert rfc822-to-8bit (ORCPT ); Tue, 31 May 2011 20:46:51 -0400 Received: by yxs7 with SMTP id 7so2016495yxs.19 for ; Tue, 31 May 2011 17:46:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1306870643-7935-1-git-send-email-juhosg@openwrt.org> Date: Wed, 1 Jun 2011 08:46:50 +0800 Message-ID: (sfid-20110601_024654_206829_EFC5E60D) Subject: Re: [RFC 00/32] ath9k: add initial support for AR9330 From: Adrian Chadd To: Daniel Halperin Cc: Gabor Juhos , "John W. Linville" , linux-wireless@vger.kernel.org, Luis Rodriguez , Vasanthakumar Thiagarajan Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, On 1 June 2011 03:51, Daniel Halperin wrote: > On Tue, May 31, 2011 at 12:36 PM, Gabor Juhos wrote: >> It is a 1x1 chip and supports 2.4GHz only. > > [snip] > >> ?ath9k: enable antenna diversity for AR9330 > > I'm confused by the combination of these two. I bet it's like the AR9285 - there's one TX and one RX chain, but two RX inputs, two LNAs and some controllable bits to determine how the baseband controls how the LNAs are configured/combined for packet RX. For clarity (heh), see the diversity combining code in recv.c; it outlines the various LNA combination modes. Adrian