Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:60219 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753300Ab1FFSbU (ORCPT ); Mon, 6 Jun 2011 14:31:20 -0400 Date: Mon, 6 Jun 2011 14:24:18 -0400 From: "John W. Linville" To: Felix Fietkau Cc: Johannes Berg , linux-wireless@vger.kernel.org Subject: Re: [PATCH 2/3] mac80211: create a STA entry for a WDS interface after receiving a beacon Message-ID: <20110606182417.GF2604@tuxdriver.com> (sfid-20110606_203124_093950_734047BA) References: <1306872395.29989.3.camel@jlt3.sipsolutions.net> <4DE54E16.7000709@openwrt.org> <1306901843.3867.2.camel@jlt3.sipsolutions.net> <4DE61A11.1070708@openwrt.org> <1306926131.3867.8.camel@jlt3.sipsolutions.net> <4DE61FEA.60903@openwrt.org> <1306927838.3867.10.camel@jlt3.sipsolutions.net> <4DE6256B.80106@openwrt.org> <1306931187.3867.11.camel@jlt3.sipsolutions.net> <4DE63533.9090709@openwrt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4DE63533.9090709@openwrt.org> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jun 01, 2011 at 02:48:51PM +0200, Felix Fietkau wrote: > On 2011-06-01 2:26 PM, Johannes Berg wrote: > >On Wed, 2011-06-01 at 13:41 +0200, Felix Fietkau wrote: > >> On 2011-06-01 1:30 PM, Johannes Berg wrote: > >> > On Wed, 2011-06-01 at 13:18 +0200, Felix Fietkau wrote: > >> > > >> >> >> >> >> > I don't understand how you can rely on beacons for WDS. > >> > > >> >> Oh, right. I'll send a follow-up patch that forces a WDS to also have an > >> >> active AP interface before it's brought up. > >> > > >> > Hm, that might be sufficient, but what if the peer isn't sending > >> > beacons? > >> > > >> > Can't we add a station entry and then update it if we receive > >> > information from the peer? That'd be more compatible with others devices > >> > that don't necessarily have beacons with WDS, and then we wouldn't have > >> > to require it locally either (since realistically we might have to > >> > interoperate with those anyway?) > >> What other devices use WDS without beacons? So far I haven't seen any. > > > >I don't know, at least older mac80211 could do that? > In older mac80211 (at least the versions that I tested), WDS was > completely broken. It also created the station entry without any > valid rates, and it had no means of updating the supported rates > list. Is this settled? Do we want these patches? -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.