Return-path: Received: from mail-gx0-f174.google.com ([209.85.161.174]:43018 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754214Ab1GLCzI (ORCPT ); Mon, 11 Jul 2011 22:55:08 -0400 Received: by gxk21 with SMTP id 21so1766092gxk.19 for ; Mon, 11 Jul 2011 19:55:08 -0700 (PDT) Message-ID: <4E1BB788.2010405@lwfinger.net> (sfid-20110712_045517_346056_73D406FA) Date: Mon, 11 Jul 2011 21:55:04 -0500 From: Larry Finger MIME-Version: 1.0 To: ali@internetdog.org CC: linux-wireless@vger.kernel.org, WLAN FAE Subject: Re: [PATCH 0/2] staging: r8712u: Set ESSID/AP now possible before interface is brought Up. References: <1310378876-1311-1-git-send-email-ali@internetDog.org> <4E1B1D60.9030509@lwfinger.net> <20110712020049.GA6364@internetdog.org> In-Reply-To: <20110712020049.GA6364@internetdog.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 07/11/2011 09:00 PM, Ali Bahar wrote: > On Mon, Jul 11, 2011 at 10:57:20AM -0500, Larry Finger wrote: >> On 07/11/2011 05:07 AM, Ali Bahar wrote: >>> These are updates to how the 'bup' flag is handled. The first allows Sets >>> before the interface is brought Up, and the second is housekeeping of the >>> flag's value when the interface is taken Down. >>> >>> Ali Bahar (2): >>> staging: r8712u: Sets to SSID, and to AP MAC#, can now be done >>> when the interface is Down. >>> staging: r8712u: Interface-state not fully tracked. >>> >>> drivers/staging/rtl8712/drv_types.h | 5 +++++ >>> drivers/staging/rtl8712/os_intfs.c | 14 ++++++++++++++ >>> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 25 +++++++++++++++++++++---- >>> 3 files changed, 40 insertions(+), 4 deletions(-) >>> >> >> Ali, >> >> The patches look good, except for one problem. As this driver is in >> staging, the patches need to be sent to Greg Kroah-Hartman >> , not through linux-wireless. > > Hmm, I must admit that I'd raised this question with myself (ie > Staging's recipients), and had dug into it a bit, but neglected it at > the last minute. Sorry. > > See below, anyway. > > >> One other point - for those patches that are properly sent through >> wireless, John Linville should be the one to receive those. He is >> the maintainer for that section, just as GregKH is the maintainer >> for staging. > > Yes, but my understanding was that _you_ are my upstream, since you > are this driver's maintainer. (MAINTAINERS does not mention you for > exactly the r8712u, but does so for related devices.) So it was going > to be To: Larry, CC: wireless ML. Observing other threads suggested > that you may then Ack and send it to Linville -- which, now that you > have reminded me, would have been Greg KH. > > OK, so I will re-send these to Greg. Do you not get even a CC?!! You > mention none, above, and had offered/expected to review them (in a 3 > July email.) > > (NB I ruled out a CC to linuxdriverproject.org, of course.) I am one of the driver's authors, not a maintainer. You should send any patches for a staging driver to GregKH, and Cc all of the driver authors. As I am the only one listed, you only need send these to me. You will need me to ACK the patch, otherwise Greg is unlikely to pick it up, particularly as it does more than make cosmetic changes. Larry